From a96a641be3850bc7a16ccd06a49b882f851c6444 Mon Sep 17 00:00:00 2001 From: QQ Date: Sat, 14 Nov 2026 14:44:42 +0800 Subject: [PATCH] Import packages/client-core/tests/codex-client.test.ts --- .../client-core/tests/codex-client.test.ts | 343 ++++++++++++++++++ 1 file changed, 343 insertions(+) create mode 100644 packages/client-core/tests/codex-client.test.ts diff --git a/packages/client-core/tests/codex-client.test.ts b/packages/client-core/tests/codex-client.test.ts new file mode 100644 index 0000000..b0eb7ec --- /dev/null +++ b/packages/client-core/tests/codex-client.test.ts @@ -0,0 +1,343 @@ +import { describe, expect, it, vi } from 'vitest' +import { + CodexRemoteClient, + createCodexTimelineState, + deriveCodexCwdWorkspaces, + projectCodexHistory, + projectCodexThread, + reduceCodexTimelineFrame, +} from '../src/codex-client.js' + +describe('Codex display projection', () => { + it('keeps the first user message as an untitled thread preview across live updates and history reads', () => { + const user = { id: 'u1', type: 'userMessage', content: [{ type: 'text', text: ' Check\n the latest PR ' }] } + const initial = createCodexTimelineState({ id: 'untitled', turns: [] })! + const started = reduceCodexTimelineFrame(initial, { + method: 'item/started', params: { turnId: 't1', item: user }, + }) + expect(started.session).toMatchObject({ preview: 'Check the latest PR' }) + expect(started.session.title).toBeUndefined() + const later = reduceCodexTimelineFrame(started, { + method: 'item/completed', params: { turnId: 't2', item: { ...user, id: 'u2', content: [{ type: 'text', text: 'Second prompt' }] } }, + }) + expect(later.session.preview).toBe('Check the latest PR') + const renamed = reduceCodexTimelineFrame(later, { + method: 'thread/name/updated', params: { threadName: 'PR review' }, + }) + expect(renamed.session.title).toBe('PR review') + expect(projectCodexThread({ id: 'untitled', turns: [{ id: 't1', items: [user] }] })?.preview).toBe('Check the latest PR') + expect(projectCodexThread({ id: 'untitled', preview: 'Server preview', turns: [{ id: 't1', items: [user] }] })?.preview).toBe('Server preview') + const imageOnly = createCodexTimelineState({ id: 'image', turns: [{ id: 't1', items: [{ id: 'u1', type: 'userMessage', content: [{ type: 'image', url: 'data:image/png;base64,aA==' }] }] }] })! + expect(imageOnly.session.preview).toBeUndefined() + }) + + it('uses the bounded Codex transfer path for image prompt input', async () => { + const rpc = vi.fn(async (method: string) => { + if (method === 'codex.app.transfer.commit') return { kind: 'inline', response: { turn: { id: 'turn_1' } } } + return { accepted: true } + }) + const client = new CodexRemoteClient({ rpc } as never) + + await client.request('turn/start', { + threadId: 'thr_1', + input: [{ type: 'image', mediaType: 'image/png', data: 'aW1hZ2U=' }], + }) + + expect(rpc).not.toHaveBeenCalledWith('codex.app.call', expect.anything(), expect.anything()) + expect(rpc).toHaveBeenCalledWith('codex.app.transfer.open', expect.objectContaining({ totalChunks: 1 }), undefined) + expect(rpc).toHaveBeenCalledWith('codex.app.transfer.chunk', expect.objectContaining({ index: 0 }), undefined) + expect(rpc).toHaveBeenCalledWith('codex.app.transfer.commit', expect.anything(), undefined) + }) + + it('keeps Codex identity namespaced and separate from Harness sessions', () => { + expect(projectCodexThread({ + id: 'thr_123', + sessionId: 'tree_1', + name: 'Fix CI', + preview: 'Investigate the failing build', + cwd: '/workspace/repo', + createdAt: 1_700_000_000, + updatedAt: 1_700_000_100, + isPinned: true, + status: { type: 'active', activeFlags: ['waitingOnApproval'] }, + })).toEqual({ + id: 'codex:thr_123', + backend: 'codex', + nativeId: 'thr_123', + sessionTreeId: 'tree_1', + title: 'Fix CI', + preview: 'Investigate the failing build', + cwd: '/workspace/repo', + createdAt: 1_700_000_000_000, + updatedAt: 1_700_000_100_000, + status: 'waiting', + pinned: true, + }) + }) + + it('projects the current model from the latest CodeX Turn', () => { + expect(projectCodexThread({ + id: 'thr_model', + model: 'stale-model', + turns: [ + { id: 'turn_old', model: 'old-model', reasoningEffort: 'low' }, + { id: 'turn_new', model: 'gpt-5.6-terra', effort: 'high' }, + ], + })).toMatchObject({ model: 'gpt-5.6-terra', reasoningEffort: 'high' }) + }) + + it('derives deterministic fallback workspaces from unique Thread cwd values', () => { + const workspaces = deriveCodexCwdWorkspaces([ + { id: 'thr_1', cwd: '/workspace/repo/', createdAt: 20, updatedAt: 30 }, + { id: 'thr_2', cwd: '/workspace/repo', createdAt: 10, updatedAt: 40 }, + { id: 'thr_3', cwd: '/workspace/other', createdAt: 15, updatedAt: 25 }, + { id: 'thr_4' }, + { id: 'thr_5', cwd: 'relative/not-allowed' }, + ]) + + expect(workspaces).toEqual([ + { + id: expect.stringMatching(/^cwd-/u), + name: 'repo', + path: '/workspace/repo/', + position: 0, + createdAt: 10_000, + updatedAt: 40_000, + }, + { + id: expect.stringMatching(/^cwd-/u), + name: 'other', + path: '/workspace/other', + position: 1, + createdAt: 15_000, + updatedAt: 25_000, + }, + ]) + expect(workspaces[0]!.id).not.toBe(workspaces[1]!.id) + expect(deriveCodexCwdWorkspaces([{ id: 'thr_5', cwd: '/workspace/repo/' }])[0]!.id) + .toBe(workspaces[0]!.id) + }) + + it('projects messages and tool lifecycle with a safe unknown fallback', () => { + const items = projectCodexHistory({ + id: 'thr_123', + turns: [{ + id: 'turn_1', + items: [ + { id: 'u1', type: 'userMessage', content: [{ type: 'text', text: 'Run tests' }] }, + { id: 'a1', type: 'agentMessage', text: 'I will inspect CI.', status: 'completed' }, + { id: 'c1', type: 'commandExecution', command: 'pnpm test', aggregatedOutput: '3 passed', status: 'completed' }, + { id: 'f1', type: 'fileChange', changes: [{ kind: 'update', path: 'src/index.ts', diff: '@@' }], status: 'completed' }, + { id: 'future1', type: 'futureCodexItem', secret: 'not projected' }, + ], + }], + }) + + expect(items).toMatchObject([ + { id: 'codex:thr_123:turn_1:u1', backend: 'codex', kind: 'message', role: 'user', text: 'Run tests' }, + { id: 'codex:thr_123:turn_1:a1', kind: 'message', role: 'assistant', text: 'I will inspect CI.' }, + { id: 'codex:thr_123:turn_1:c1', kind: 'tool', text: 'pnpm test\n\n3 passed', status: 'completed' }, + { id: 'codex:thr_123:turn_1:f1', kind: 'file-change', text: '[update] src/index.ts', status: 'completed' }, + { id: 'codex:thr_123:turn_1:future1', kind: 'unknown', details: { type: 'futureCodexItem' } }, + ]) + expect(JSON.stringify(items)).not.toContain('not projected') + expect(JSON.stringify(items)).not.toContain('@@') + }) + + it('keeps safe Codex message images in the display projection', () => { + const items = projectCodexHistory({ + id: 'thr_123', + turns: [{ + id: 'turn_1', + items: [ + { + id: 'u-image', + type: 'userMessage', + content: [ + { type: 'text', text: 'Look at this' }, + { type: 'image', url: 'data:image/png;base64,aW1hZ2U=', name: 'screen.png' }, + { type: 'image', url: 'https://example.test/not-allowed.png', name: 'external.png' }, + ], + }, + { + id: 'a-image', + type: 'agentMessage', + content: [{ type: 'input_image', image_url: 'data:image/gif;base64,R0lGODlhAQABAAAAACw=' }], + status: 'completed', + }, + { + id: 'tool-image', + type: 'mcpToolCall', + server: 'cua_repl', + tool: 'js', + result: { content: [ + { type: 'text', text: '/workspace/current-browser.png' }, + { type: 'image', mimeType: 'image/png', data: 'aW1hZ2U=', name: 'current-browser.png' }, + ] }, + status: 'completed', + }, + ], + }], + }) + + expect(items).toMatchObject([ + { + id: 'codex:thr_123:turn_1:u-image', + kind: 'message', + role: 'user', + text: 'Look at this', + images: [{ uri: 'data:image/png;base64,aW1hZ2U=', name: 'screen.png' }], + }, + { + id: 'codex:thr_123:turn_1:a-image', + kind: 'message', + role: 'assistant', + images: [{ uri: 'data:image/gif;base64,R0lGODlhAQABAAAAACw=' }], + }, + { + id: 'codex:thr_123:turn_1:tool-image', + kind: 'tool', + text: 'js\n\n/workspace/current-browser.png', + images: [{ uri: 'data:image/png;base64,aW1hZ2U=', name: 'current-browser.png' }], + }, + ]) + expect(JSON.stringify(items)).not.toContain('example.test') + }) + + it('reduces live item deltas, completion, status, and one-time approvals over a baseline', () => { + let state = createCodexTimelineState({ + id: 'thr_123', + cwd: '/workspace/repo', + createdAt: 1, + updatedAt: 2, + status: { type: 'idle' }, + turns: [], + })! + state = reduceCodexTimelineFrame(state, { + method: 'thread/name/updated', + params: { threadId: 'thr_123', threadName: 'Generated CodeX title' }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'turn/started', + params: { threadId: 'thr_123', turn: { id: 'turn_1', status: 'inProgress', items: [] } }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'item/agentMessage/delta', + params: { threadId: 'thr_123', turnId: 'turn_1', itemId: 'agent_1', delta: 'Hello' }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'item/agentMessage/delta', + params: { threadId: 'thr_123', turnId: 'turn_1', itemId: 'agent_1', delta: ' world' }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'item/commandExecution/requestApproval', + params: { + threadId: 'thr_123', + turnId: 'turn_1', + requestHandle: 'opaque-handle', + command: ['pnpm', 'test'], + }, + }) + + expect(state).toMatchObject({ + activeTurnId: 'turn_1', + approval: { requestHandle: 'opaque-handle', kind: 'command', command: 'pnpm test' }, + session: { title: 'Generated CodeX title', status: 'waiting' }, + }) + expect(state.items).toMatchObject([ + { kind: 'message', role: 'assistant', text: 'Hello world', status: 'running' }, + { kind: 'approval', text: 'pnpm test', status: 'running' }, + ]) + + state = reduceCodexTimelineFrame(state, { + method: 'item/completed', + params: { + threadId: 'thr_123', + turnId: 'turn_1', + item: { id: 'agent_1', type: 'agentMessage', text: 'Hello world.', status: 'completed' }, + }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'turn/completed', + params: { threadId: 'thr_123', turn: { id: 'turn_1', status: 'completed', items: [] } }, + }) + + expect(state.activeTurnId).toBeUndefined() + expect(state.approval).toBeUndefined() + expect(state.session.status).toBe('idle') + expect(state.items[0]).toMatchObject({ text: 'Hello world.', status: 'completed' }) + }) + + it('clears an active turn when the App Server reports an idle or system error status', () => { + let state = createCodexTimelineState({ + id: 'thr_status', cwd: '/workspace/repo', createdAt: 1, updatedAt: 2, + status: { type: 'idle' }, turns: [], + })! + state = reduceCodexTimelineFrame(state, { + method: 'turn/started', + params: { turn: { id: 'turn_status', status: 'inProgress', items: [] } }, + }) + expect(state.activeTurnId).toBe('turn_status') + + state = reduceCodexTimelineFrame(state, { + method: 'thread/status/changed', + params: { status: { type: 'idle' } }, + }) + expect(state).toMatchObject({ session: { status: 'idle' } }) + expect(state.activeTurnId).toBeUndefined() + expect(state.items.every(item => item.status !== 'running')).toBe(true) + + state = reduceCodexTimelineFrame(state, { + method: 'turn/started', + params: { turn: { id: 'turn_error', status: 'inProgress', items: [] } }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'thread/status/changed', + params: { status: { type: 'systemError' } }, + }) + expect(state).toMatchObject({ session: { status: 'failed' } }) + expect(state.activeTurnId).toBeUndefined() + expect(state.items.every(item => item.status !== 'running')).toBe(true) + }) + + it('merges command, file-change, and approval-resolution notifications by native item id', () => { + let state = createCodexTimelineState({ + id: 'thr_123', cwd: '/workspace/repo', createdAt: 1, updatedAt: 2, turns: [], + })! + state = reduceCodexTimelineFrame(state, { + method: 'turn/started', + params: { turn: { id: 'turn_1', status: 'inProgress', items: [] } }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'item/started', + params: { turnId: 'turn_1', item: { id: 'cmd_1', type: 'commandExecution', command: 'pnpm test', status: 'inProgress' } }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'item/commandExecution/outputDelta', + params: { turnId: 'turn_1', itemId: 'cmd_1', delta: '\n1 passed' }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'item/started', + params: { turnId: 'turn_1', item: { id: 'files_1', type: 'fileChange', changes: [], status: 'inProgress' } }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'item/fileChange/patchUpdated', + params: { turnId: 'turn_1', itemId: 'files_1', changes: [{ kind: 'add', path: 'new.ts' }] }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'item/fileChange/requestApproval', + params: { turnId: 'turn_1', requestHandle: 'approval_1' }, + }) + state = reduceCodexTimelineFrame(state, { + method: 'serverRequest/resolved', + params: { turnId: 'turn_1', requestId: 1 }, + }) + + expect(state.approval).toBeUndefined() + expect(state.items).toMatchObject([ + { nativeRef: { itemId: 'cmd_1' }, text: 'pnpm test\n1 passed', status: 'running' }, + { nativeRef: { itemId: 'files_1' }, text: '[add] new.ts', status: 'running' }, + { nativeRef: { requestHandle: 'approval_1' }, status: 'completed' }, + ]) + }) +})