fix(workbench-panel): 核验状态说中文,别和「文件已失效」读成矛盾
- verification.status 直出英文 verified 时,同屏「文件已失效」像是自相矛盾 - 改 verificationLabel:已核验/未核验/未通过/核验未知;并说明「已核验」指结果被核验过,不代表文件还在 - 219/219
This commit is contained in:
parent
3d0a059bbf
commit
d479c12eaa
Binary file not shown.
|
Before Width: | Height: | Size: 34 KiB After Width: | Height: | Size: 34 KiB |
|
|
@ -792,6 +792,15 @@ window.__ModuleLoader__.load({
|
|||
return "";
|
||||
}
|
||||
|
||||
// 原始 verification.status 是英文枚举,直接摆在「文件已失效」旁边会读成自相矛盾:
|
||||
// 「已核验」说的是结果被核验过,不是文件现在还在。
|
||||
function verificationLabel(status) {
|
||||
if (status === "verified") return "已核验";
|
||||
if (status === "rejected") return "未通过";
|
||||
if (status === "unverified") return "未核验";
|
||||
return "核验未知";
|
||||
}
|
||||
|
||||
function revisionLabel(artifact) {
|
||||
var revision = Number(artifact && artifact.revision);
|
||||
if (!isFinite(revision) || revision < 1) revision = 1;
|
||||
|
|
@ -1844,7 +1853,7 @@ window.__ModuleLoader__.load({
|
|||
var existence = artifact.existence;
|
||||
var flag = existenceLabel(existence);
|
||||
var missing = existence === "missing";
|
||||
var metaChildren = [owner + " · " + (artifact.mediaType || "未知类型") + " · " + verify];
|
||||
var metaChildren = [owner + " · " + (artifact.mediaType || "未知类型") + " · " + verificationLabel(verify)];
|
||||
if (flag) {
|
||||
metaChildren.push(h("span", {
|
||||
className: "wb-artifact-flag" + (existence === "unknown" ? " is-unknown" : ""),
|
||||
|
|
@ -2220,6 +2229,7 @@ window.__ModuleLoader__.load({
|
|||
seatDisplayName: seatDisplayName,
|
||||
modelTitle: modelTitle,
|
||||
existenceLabel: existenceLabel,
|
||||
verificationLabel: verificationLabel,
|
||||
revisionLabel: revisionLabel,
|
||||
taskKindLabel: taskKindLabel,
|
||||
taskActionKeys: taskActionKeys,
|
||||
|
|
|
|||
|
|
@ -492,6 +492,18 @@ test("existenceLabel:missing / unknown / ok 三态,unknown 不能被当成
|
|||
assert.ok(!existenceLabel("ok").includes("正常"), "ok 也不必写正常,静默即可");
|
||||
});
|
||||
|
||||
test("verificationLabel:英文枚举翻成中文,别和「文件已失效」读成自相矛盾", function () {
|
||||
const plugin = loadPlugin();
|
||||
const { verificationLabel } = plugin.exports.__test;
|
||||
|
||||
assert.equal(verificationLabel("verified"), "已核验");
|
||||
assert.equal(verificationLabel("unverified"), "未核验");
|
||||
assert.equal(verificationLabel("rejected"), "未通过");
|
||||
assert.equal(verificationLabel(undefined), "核验未知");
|
||||
// 「已核验」说的是结果被核验过,不是文件还在——不能出现「存在」「有效」这类字眼。
|
||||
assert.ok(!/存在|有效/.test(verificationLabel("verified")));
|
||||
});
|
||||
|
||||
test("revisionLabel:第 N 版,只有真正修订且 N>1 才写「修订自上一版」", function () {
|
||||
const plugin = loadPlugin();
|
||||
const { revisionLabel } = plugin.exports.__test;
|
||||
|
|
|
|||
Loading…
Reference in New Issue